New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdHocFilters: add hidden option #1012

Merged

mikkancso merged 2 commits into main from mikkancso/add-hidden-filter

Jan 7, 2025

+37 −5

Contributor

mikkancso commented Dec 20, 2024

We'd like to add a search input field to a page which already has AdHocFilters with a restricted set of keywords. We have the following requirements:

when a search term is supplied, then all the queries on the page should be filtered as if there was a filter added for the a specific, fixed label. More precisely it should be equivalent to adding specific_label=~.*searchTerm.*
but we don't want this new filter to be shown by the AdHocFilter control (we currently use VariableValueControl for that) or the URL

This PR enables us to achieve this by introducing the hidden property on AdHocFilters.

Related discussion: https://raintank-corp.slack.com/archives/C04FRQ2S0AV/p1732712478401569


          add hidden option to AdHocFilters

88e9d95

dprokop reviewed

View reviewed changes

Member

dprokop left a comment

Let's add tests for that and should be ok to go!


          add tests

f8370fd

dprokop approved these changes

View reviewed changes

mikkancso merged commit 03842ba into main

5 checks passed

mikkancso deleted the mikkancso/add-hidden-filter branch

January 7, 2025 08:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet